fix: skip parse_document when policy fetch fails in iam__enum_permissions#504
Open
raajheshkannaa wants to merge 1 commit intoRhinoSecurityLabs:masterfrom
Open
Conversation
…tch fails When get_role_policy, get_group_policy, or get_user_policy throws ClientError, the document variable is never assigned but parse_document is still called with it, causing an UnboundLocalError. Add continue to skip parsing when the API call fails. Fixes RhinoSecurityLabs#445
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnboundLocalError: cannot access local variable 'document'whenget_role_policy,get_group_policy, orget_user_policyfails withClientErrorPermissionsConfirmed = False, but execution falls through toparse_document(document, ...)wheredocumentwas never assignedcontinuein three error handlers so the loop skips to the next policy instead of crashingFixes #445